Skip to content

Docs: Split up Build Notifications into feature/reference and how-to (Diátaxis) #9686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Oct 21, 2022

This made a lot of sense.

I had to write new text for the old feature description, though. But I think that text was already missing in the former version.

@benjaoming benjaoming added the Improvement Minor improvement to code label Oct 21, 2022
@benjaoming benjaoming requested a review from a team as a code owner October 21, 2022 16:01
* Submit the form
.. seealso::
:doc:`/guides/build-notifications`
All the practical steps for setting up build notifications
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above added lines are all new texts.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better refactor. I think we can continue to build out the feature pages, but at least this has one 👍

@benjaoming benjaoming merged commit 9cbd50a into readthedocs:main Nov 1, 2022
@benjaoming benjaoming deleted the diataxis/build-notifications branch November 1, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants