Redirects: allow update #9593
Merged
Redirects: allow update #9593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Sep 8, 2022
Comment on lines
-688
to
-699
| def save(self, **_): # pylint: disable=arguments-differ | ||
| # TODO this should respect the unused argument `commit`. It's not clear | ||
| # why this needs to be a call to `create`, instead of relying on the | ||
| # super `save()` call. | ||
| redirect = Redirect.objects.create( | ||
| project=self.project, | ||
| redirect_type=self.cleaned_data["redirect_type"], | ||
| from_url=self.cleaned_data["from_url"], | ||
| to_url=self.cleaned_data["to_url"], | ||
| force=self.cleaned_data.get("force", False), | ||
| ) | ||
| return redirect |
There was a problem hiding this comment.
We were doing this override to allow passing the project, but by using the trick of listing the project field and always using the project we pass to form this isn't needed anymore.
Comment on lines
-42
to
-63
| $('#id_from_url').parent().hide() | ||
| $('#id_to_url').parent().hide() | ||
| $('#dynamic-redirect').hide() | ||
|
|
||
| update_outcome(); | ||
| $('#id_redirect_type').bind('change', function(ev) { | ||
| $('#id_from_url').val(''); | ||
| $('#id_to_url').val(''); | ||
| $('#id_from_url').parent().hide() | ||
| $('#id_to_url').parent().hide() | ||
|
|
||
| if (this.value == 'prefix') { | ||
| $('#id_from_url').parent().show() | ||
| $('#id_to_url').parent().hide() | ||
| } | ||
| else if (this.value == 'page') { | ||
| $('#id_from_url').parent().show() | ||
| $('#id_to_url').parent().show() | ||
| } | ||
| else if (this.value == 'exact') { | ||
| $('#id_from_url').parent().show() | ||
| $('#id_to_url').parent().show() | ||
| } |
There was a problem hiding this comment.
moved this logic to be inside the update_outcome function, this way it works when the form has pre-populated fields when editing an existing redirect.
There was a problem hiding this comment.
I didn't fully check this Javascript code, but looks good!
humitos
approved these changes
Sep 14, 2022
Comment on lines
-42
to
-63
| $('#id_from_url').parent().hide() | ||
| $('#id_to_url').parent().hide() | ||
| $('#dynamic-redirect').hide() | ||
|
|
||
| update_outcome(); | ||
| $('#id_redirect_type').bind('change', function(ev) { | ||
| $('#id_from_url').val(''); | ||
| $('#id_to_url').val(''); | ||
| $('#id_from_url').parent().hide() | ||
| $('#id_to_url').parent().hide() | ||
|
|
||
| if (this.value == 'prefix') { | ||
| $('#id_from_url').parent().show() | ||
| $('#id_to_url').parent().hide() | ||
| } | ||
| else if (this.value == 'page') { | ||
| $('#id_from_url').parent().show() | ||
| $('#id_to_url').parent().show() | ||
| } | ||
| else if (this.value == 'exact') { | ||
| $('#id_from_url').parent().show() | ||
| $('#id_to_url').parent().show() | ||
| } |
There was a problem hiding this comment.
I didn't fully check this Javascript code, but looks good!
Co-authored-by: Manuel Kaufmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we already allow updating redirects via the API https://docs.readthedocs.io/en/stable/api/v3.html#redirect-update, so this allows updating redirects from the UI. I have moved the form to its own page as we do with more of our CRUD operations.
Closes #9418.
📚 Documentation previews 📚
docs): https://docs--9593.org.readthedocs.build/en/9593/dev): https://dev--9593.org.readthedocs.build/en/9593/