Build: upgrade commonmark to 0.9.1
#9563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we are installing an older version of `commonmark` that has some problems with newer versions of Python. Upgrading it to 0.9.1 seems to solve this problem. See #9562 for a detailed explanation of the problem
|
What's the workflow for adding commits on a PR that it was already hotfixed into |
|
We could also hotfix the new commits on this PR, or alternatively (and probably my suggestion) move on to a new PR -- that is, treat this PR as hotfix, merge it, and follow up with a PR that is not hotfix for the new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are installing an older version of
commonmarkthat has someproblems with newer versions of Python. Upgrading it to 0.9.1 seems to solve
this problem.
See #9562 for a detailed explanation of the problem
📚 Documentation previews 📚
docs): https://docs--9563.org.readthedocs.build/en/9563/dev): https://dev--9563.org.readthedocs.build/en/9563/