Subscriptions: use stripe subscriptions to show details #9550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Aug 25, 2022
humitos
requested changes
Aug 30, 2022
There was a problem hiding this comment.
Looks good! I think it's pretty close to get merged. Before merging, I think we need to solve the problems with
-
Organizations without.stripe_idnor.stripe_customerhitting the subscription's detail page - date for period end on subscription's detail page for "unpaid" or "past_due" subscriptions
Comment on lines
+124
to
+126
| if not subscription: | ||
| # This only happens during development. | ||
| return None |
There was a problem hiding this comment.
Does it makes sense to use the following?
Suggested change
| if not subscription: | |
| # This only happens during development. | |
| return None | |
| if settings.DEBUG and not subscription: | |
| # This only happens during development. | |
| return None |
readthedocs/subscriptions/templates/subscriptions/subscription_detail.html
Show resolved
Hide resolved
readthedocs/subscriptions/templates/subscriptions/subscription_detail.html
Show resolved
Hide resolved
readthedocs/subscriptions/templates/subscriptions/subscription_detail.html
Show resolved
Hide resolved
humitos
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9312
📚 Documentation previews 📚
docs): https://docs--9550.org.readthedocs.build/en/9550/dev): https://dev--9550.org.readthedocs.build/en/9550/