-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Build: cancel old builds #9549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Build: cancel old builds #9549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap the code that cancels a build and move it the module where `trigger_build` and other related helpers are.
This commit implements a simple logic to cancel old running builds when a new build for the same project/version arrives: 1. look for running builds for the same project/version 2. if there are any, it cancels them all one by one via Celery's revoke method 3. trigger a new build for the current commit received Note that this new feature is behind a feature flag (`CANCEL_OLD_BUILDS`) for now so we can start testing it on some projects that have shown their interest on this feature. The current behavior for `DEDUPLICATE_BUILDS` will be replaced by this new logic in the future. However, it was not removed in this commit since it's still useful for projects that won't be using the new feature flag yet. Closes #8961
I've been experiencing with this locally and the experience as a user is great 💯 .
I don't have to wait for the old build to finish and show me outdated documentation 💪🏼 |
stsewd
approved these changes
Aug 29, 2022
Co-authored-by: Santos Gallegos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a simple logic to cancel old running builds when a new
build for the same project/version arrives:
Note that this new feature is behind a feature flag (
CANCEL_OLD_BUILDS
) fornow so we can start testing it on some projects that have shown their interest
on this feature.
The current behavior for
DEDUPLICATE_BUILDS
will be replaced by this new logicin the future. However, it was not removed in this commit since it's still
useful for projects that won't be using the new feature flag yet.
Closes #8961
📚 Documentation previews 📚
docs
): https://docs--9549.org.readthedocs.build/en/9549/dev
): https://dev--9549.org.readthedocs.build/en/9549/