-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Change mailing list subscription to when the user validates their email #9384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change also adds support for subscribing the user to an onboarding group. Users in this group will get custom onboarding message(s), to help them along on their usage of the platform.
MAILERLITE_API_SUBSCRIBERS_URL = 'https://api.mailerlite.com/api/v2/subscribers' | ||
MAILERLITE_API_ONBOARDING_GROUP_URL = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to use the other value somewhere else? Looks like we are using just one of these settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it's just group specific so didn't get included in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericholscher Do we need to create an -ops PR for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good improvement to reduce the spam emails added to our newsletter! 💯
I found this PR today and looks useful. I'm commenting here to bump it up in your notifications, @ericholscher. It would be good to update if needed and merge it. |
@humitos Yea, I've had it open in a tab for a couple weeks now trying to get back to it. It's still on my roadmap, just need to find the time to finish it up. |
I re-read this PR today and I'm not sure how it works on the MailerLite side and what use cases exactly it covers. I understand that we have a "Onboard" (or similar) group on MailerLite that we add new users to it when the verify their email. At this point, MailerLite, somehow sends them the first onboarding email:
I may be confusing some things here and it may be easy for you to explain me this in a call. As you prefer. |
@humitos The tooling has support for sending campaigns to users who have signed up in a specific sequence. I don't really understand your questions though? We just only send the campaign when users are added, and it has a specific schedule. |
All doubts are cleared out after chatting with you, 👍🏼 |
…bscribe-users-on-email-validation
Co-authored-by: Santos Gallegos <[email protected]>
…thedocs/readthedocs.org into subscribe-users-on-email-validation
@ericholscher I updated this PR with the migration required. Let me know if there is something missing here. I'd love to deploy this next week so we can start sending emails to new users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. Excited to ship it 👍
Co-authored-by: Eric Holscher <[email protected]>
This change also adds support for subscribing the user to an onboarding group.
Users in this group will get custom onboarding message(s),
to help them along on their usage of the platform.
Refs https://github.com/readthedocs/readthedocs-corporate/issues/1394