Skip to content

Change mailing list subscription to when the user validates their email #9384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 14, 2022

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 28, 2022

This change also adds support for subscribing the user to an onboarding group.
Users in this group will get custom onboarding message(s),
to help them along on their usage of the platform.

Refs https://github.com/readthedocs/readthedocs-corporate/issues/1394

This change also adds support for subscribing the user to an onboarding group.
Users in this group will get custom onboarding message(s),
to help them along on their usage of the platform.
@ericholscher ericholscher requested a review from a team as a code owner June 28, 2022 21:55
@ericholscher ericholscher requested a review from stsewd June 28, 2022 21:55
Comment on lines 908 to +909
MAILERLITE_API_SUBSCRIBERS_URL = 'https://api.mailerlite.com/api/v2/subscribers'
MAILERLITE_API_ONBOARDING_GROUP_URL = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to use the other value somewhere else? Looks like we are using just one of these settings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it's just group specific so didn't get included in the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericholscher Do we need to create an -ops PR for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement to reduce the spam emails added to our newsletter! 💯

@humitos
Copy link
Member

humitos commented Jul 19, 2022

I found this PR today and looks useful. I'm commenting here to bump it up in your notifications, @ericholscher. It would be good to update if needed and merge it.

@ericholscher
Copy link
Member Author

@humitos Yea, I've had it open in a tab for a couple weeks now trying to get back to it. It's still on my roadmap, just need to find the time to finish it up.

@humitos
Copy link
Member

humitos commented Nov 9, 2022

@ericholscher

I re-read this PR today and I'm not sure how it works on the MailerLite side and what use cases exactly it covers.

I understand that we have a "Onboard" (or similar) group on MailerLite that we add new users to it when the verify their email. At this point, MailerLite, somehow sends them the first onboarding email:

  • how does it differentiate from new users and old users of that group?
  • how do we tell MailerLite to send emails to these new users, but after 3 days they have subscribed?

I may be confusing some things here and it may be easy for you to explain me this in a call. As you prefer.

@ericholscher
Copy link
Member Author

@humitos The tooling has support for sending campaigns to users who have signed up in a specific sequence. I don't really understand your questions though? We just only send the campaign when users are added, and it has a specific schedule.

@humitos
Copy link
Member

humitos commented Nov 9, 2022

All doubts are cleared out after chatting with you, 👍🏼

@humitos humitos requested a review from stsewd November 10, 2022 11:02
@humitos
Copy link
Member

humitos commented Nov 10, 2022

@ericholscher I updated this PR with the migration required. Let me know if there is something missing here. I'd love to deploy this next week so we can start sending emails to new users.

Copy link
Member Author

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Excited to ship it 👍

@humitos humitos enabled auto-merge (squash) November 14, 2022 10:02
@humitos humitos merged commit 5e870d4 into main Nov 14, 2022
@humitos humitos deleted the subscribe-users-on-email-validation branch November 14, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants