Middleware: use regular HttpResponse and log the suspicious operation
#9366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use `raise SuspiciousOperation` here because that ends up into Sentry marked as an error logged via logger `django.security.SuspiciousOperation`. I prefer to use regular `log.info` for these situations so they end up in NewRelic and we can parse them nicely. They are not application errors.
humitos
force-pushed
the
humitos/null-character-middleware
branch
from
02fb18f to
55f4d11
Compare
stsewd
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use
raise SuspiciousOperationhere because that ends up into Sentrymarked as an error logged via logger
django.security.SuspiciousOperation.I prefer to use regular
log.infofor these situations so they end up in NewRelicand we can parse them nicely. They are not application errors.