Skip to content

Development: remove silent and use long attribute name #9363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 21, 2022

  • remove -s (silent) because it takes some time to download the file and we
    don't know what it's happening; I cancelled the process multiple times due to
    this

  • use --disable instead -d since it's more expressive

- remove `-s` (silent) because it takes some time to download the file and we
  don't know what it's happening; I cancelled the process multiple times due to
  this

- use `--disable` instead `-d` since it's more expressive
@humitos humitos requested a review from benjaoming June 21, 2022 16:42
@humitos humitos requested a review from a team as a code owner June 21, 2022 16:42
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing - and oh - haha - I thought it was some coincidence/exception when I thought it was funny how MinIO's CDN was slow... it is actually slow? 🥶

@humitos humitos merged commit 93da526 into main Jun 22, 2022
@humitos humitos deleted the humitos/mc-docker-installation branch June 22, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants