Skip to content

Subscriptions: log subscription id when canceling #9340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2022
Merged

Subscriptions: log subscription id when canceling #9340

merged 2 commits into from
Jun 16, 2022

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 15, 2022

No description provided.

@stsewd stsewd marked this pull request as ready for review June 15, 2022 22:42
@stsewd stsewd requested a review from a team as a code owner June 15, 2022 22:42
@stsewd stsewd requested a review from benjaoming June 15, 2022 22:42
humitos
humitos approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a similar log line in delete_customer from the same file.

@stsewd stsewd merged commit 0a0af81 into main Jun 16, 2022
@stsewd stsewd deleted the log-subs-id-when-canceling branch June 16, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@benjaoming benjaoming Awaiting requested review from benjaoming benjaoming is a code owner automatically assigned from readthedocs/backend

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos