Tests: make tests-embedapi require regular tests first
#9289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm adding this requirement so we don't trigger all the tests concurrently and also avoid running EmbedAPI tests if there is a failure on any of the other two. This way we will be saving some resources here. EmbedAPI tests are _not required_ to merge a PR, so I think it's fine if they are not always run.
stsewd
reviewed
Jun 2, 2022
Co-authored-by: Santos Gallegos <[email protected]>
stsewd
approved these changes
Jun 6, 2022
|
It seems it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding this requirement so we don't trigger all the tests concurrently and
also avoid running EmbedAPI tests if there is a failure on any of the other two.
This way we will be saving some resources here.
EmbedAPI tests are not required to merge a PR, so I think it's fine if they
are not always run.