Truncate output that we log from commands to 10 lines #9286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Jun 1, 2022
humitos
approved these changes
Jun 2, 2022
| @@ -457,7 +457,8 @@ def run_command_class( | |||
| if warn_only: | |||
| msg = 'Command {cmd} failed'.format(cmd=build_cmd.get_command()) | |||
| if build_cmd.output: | |||
| msg += ':\n{out}'.format(out=build_cmd.output) | |||
| truncated_output = "\n".join(build_cmd.output.split("\n")[:10]) | |||
There was a problem hiding this comment.
What about logging the 10 first and the 10 last lines?
8
9
10
....
98
99
100
|
Failing test is unrelated (jupyterbook docs change) |
ericholscher
force-pushed
the
truncate-latex
branch
from
8fa5c94 to
aa045c5
Compare
Make output nicer and add first/last 10 lines Log correct string
ericholscher
force-pushed
the
truncate-latex
branch
from
aa045c5 to
9156413
Compare
humitos
added a commit
that referenced
this pull request
Jun 17, 2022
The logic wrote in #9286 was incorrect. The logs keeps showing a lot of the command's output. We want to take the first 10 lines and the last 10 lines.
stsewd
pushed a commit
that referenced
this pull request
Jun 20, 2022
The logic wrote in #9286 was incorrect. The logs keeps showing a lot of the command's output. We want to take the first 10 lines and the last 10 lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9105