Fix copy issues on model fields #9170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The term "domain" is not a proper noun and should not use proper capitalization. We do this in a number of places, as we are generally referring to the underlying model, but this shouldn't be how these terms are communicated to users. I didn't touch the actual copy otherwise, even though we could probably make these descriptions a bit clearer. We could also do that more immediately if it makes sense.
humitos
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term "domain" is not a proper noun and should not use proper
capitalization. We do this in a number of places, as we are generally
referring to the underlying model, but this shouldn't be how these terms
are communicated to users.
I didn't touch the actual copy otherwise, even though we could probably
make these descriptions a bit clearer. We could also do that more
immediately if it makes sense.