Search: fix parsing of footnotes #9154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our code to detect sphinx domains is a little naive, sphinx also doesn't make it easy to detect these.
humitos
approved these changes
May 2, 2022
Comment on lines
+412
to
+413
| A Sphinx domain is a <dl> tag which contains <dt> tags with an 'id' attribute, | ||
| dl tags that have the "footnote" class aren't domains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code to detect sphinx domains is a little naive,
sphinx also doesn't make it easy to detect these.
We were removing footnotes in the process of removing domains.
Also de code that extracts domains had a bug,
but looks like we aren't using that as the source of domains, so our domains search wasn't affected by it,
we are using the ones we have in our DB.. so not really sure about why we are parsing them at all :D (maybe this was before we stored the domains in our db?)
found this while testing docutils 18.1