Analytics: add feature flag to skip tracking 404s #9131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
We want to be able to opt certain projects in to this feature, so I think we want to invert the logic here. On .org we'll basically just keep it off for everyone, and .com we'll past_default_true and future_default_true it.
If it's inverted, I don't think we have a way to turn it on for select projects on .org, if needed.
ericholscher
approved these changes
Apr 21, 2022
ericholscher
pushed a commit
that referenced
this pull request
Apr 21, 2022
* Analytics: add feature flag to skip tracking 404s * Invert feature flag * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.