Logging: reduce verbosity #9107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In these cases, we are logging a warning message just to know that we weren't able to clone the respository. However, this is a user error in most cases it's because it's a private repository asking for user input. I'm keeping the log as warning, but removing the `exc_info` since it only adds noise currently.
We don't need to log this as an exception because most of the times this happens due a container that exited because memory limit or build timeout. We could inspect the message to make it 100% accurate, but I think it's not required. We haven't had problems with Docker in a long time. I suppose we will be fine here. In any case, this is only to kill the container. In the worst scenario, it will just keep some zombie containers in the instance, which will be killed on scale in anyways.
ericholscher
approved these changes
Apr 13, 2022
agjohnson
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce verbosity for some specific cases. Each particular case is explained in the commit message.