Skip to content

Celery: workaround fix for bug on retrying builds #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

Celery: workaround fix for bug on retrying builds #9096

merged 1 commit into from
Apr 12, 2022

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 11, 2022 •
edited
Loading

Ref #9014

@stsewd stsewd requested a review from a team as a code owner April 11, 2022 23:56
humitos
humitos approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this PR. Actually, I opened #8941 and wrote that we should use CELERY_TASK_IGNORE_RESULT=True globally so we don't store the results since we are not using them and they could generate these kinds of problems.

@humitos humitos merged commit 6541d7c into main Apr 12, 2022
@humitos humitos deleted the workaround-celery branch April 12, 2022 07:41
@humitos humitos mentioned this pull request Apr 12, 2022
Closed
@ericholscher ericholscher mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@stsewd stsewd

Labels
None yet
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos