Skip to content

Fix tests around jinja2 #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Fix tests around jinja2 #9050

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
965261c
Fix tests around jinja2
ericholscher Mar 29, 2022
70679a3
Fix one more test
ericholscher Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions readthedocs/rtd_tests/tests/test_doc_building.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from itertools import zip_longest
import os
import tempfile
import uuid
from itertools import zip_longest
from unittest import mock
from unittest.mock import Mock, PropertyMock, patch

Expand Down Expand Up @@ -407,11 +407,12 @@ def test_install_core_requirements_sphinx(self, checkout_path):
)
python_env.install_core_requirements()
requirements_sphinx = [
'commonmark',
'recommonmark',
'sphinx',
'sphinx-rtd-theme',
'readthedocs-sphinx-ext',
"commonmark",
"recommonmark",
"sphinx",
"sphinx-rtd-theme",
"readthedocs-sphinx-ext",
"jinja2<3.1.0",
]

self.assertEqual(self.build_env_mock.run.call_count, 2)
Expand Down Expand Up @@ -444,12 +445,13 @@ def test_install_core_requirements_sphinx_system_packages_caps_setuptools(self,
)
python_env.install_core_requirements()
requirements_sphinx = [
'commonmark',
'recommonmark',
'sphinx',
'sphinx-rtd-theme',
'readthedocs-sphinx-ext',
'setuptools<58.3.0',
"commonmark",
"recommonmark",
"sphinx",
"sphinx-rtd-theme",
"readthedocs-sphinx-ext",
"jinja2<3.1.0",
"setuptools<58.3.0",
]

self.assertEqual(self.build_env_mock.run.call_count, 2)
Expand Down