Skip to content

Build: Mercurial (hg) compatibility with old versions #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 28, 2022

We are using Ubuntu 20.04 LTS to perform the clone
step (readthedocs/build:ubuntu-20.04) which comes with Mercurial v5.3.1 and
install by default the sparse-revlog requirement.

However, if the build is using readthedocs/build:latest, which comes with
Mercurial v4.5.3 and does not contain that requirement it fails:

hg identify --id
abort: repository requires features unknown to this Mercurial: sparserevlog!
(see https://mercurial-scm.org/wiki/MissingRequirement for more information)

This commit disables that requirements to make the clone compatible with the
older version of Mercurial.

Closes #8995

@humitos humitos requested a review from a team as a code owner March 28, 2022 09:54
@humitos
Copy link
Member Author

humitos commented Mar 28, 2022

EmbedAPI tests fail because of the jinja issue, we need to open another PR to pin that dependency for older version of Sphinx. That failure is not related to this PR, though.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, but definitely needs some context.

We are using Ubuntu 20.04 LTS to perform the clone
step (`readthedocs/build:ubuntu-20.04`) which comes with Mercurial v5.3.1 and
install by default the `sparse-revlog` requirement.

However, if the build is using `readthedocs/build:latest`, which comes with
Mercurial v4.5.3 and does not contain that requirement it fails:

```
hg identify --id
abort: repository requires features unknown to this Mercurial: sparserevlog!
(see https://mercurial-scm.org/wiki/MissingRequirement for more information)
```

This commit disables that requirements to make the clone compatible with the
older version of Mercurial.

Closes #8995
@humitos humitos force-pushed the humitos/mercurial-compatibility branch from 3b66dab to 011c01e Compare March 29, 2022 05:10
@humitos humitos merged commit 436ad41 into main Mar 29, 2022
@humitos humitos deleted the humitos/mercurial-compatibility branch March 29, 2022 05:24
@humitos humitos self-assigned this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Build: incompatible Mercurial versions from VCS setup than build commands
2 participants