Skip to content

Add bumpver configuration #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Add bumpver configuration #9029

merged 4 commits into from
Mar 22, 2022

Conversation

agjohnson
Copy link
Contributor

This is directly called from ops/deploy, so usage of this tool is
abstracted and not super important.

It's easy to use however, and has a string input method, instead of
incrementing each part individually, a la bump2version.

% bumpver update --dry --set-version "8.0.0"
INFO    - fetching tags from remote (to turn off use: -n / --no-fetch)
INFO    - Old Version: 7.4.2
INFO    - New Version: 8.0.0
--- docs/conf.py
+++ docs/conf.py
@@ -67,7 +67,7 @@
 copyright = '2010-{}, Read the Docs, Inc & contributors'.format(
     timezone.now().year
 )
-version = "7.4.2"
+version = "8.0.0"
 release = version
 exclude_patterns = ['_build']
 default_role = 'obj'
--- package.json
+++ package.json
@@ -1,6 +1,6 @@
 {
   "name": "readthedocs",
-  "version": "7.4.2",
+  "version": "8.0.0",
   "description": "Read the Docs build dependencies",
   "author": "Read the Docs, Inc <[email protected]>",
   "scripts": {
--- readthedocs/__init__.py
+++ readthedocs/__init__.py
@@ -2,5 +2,5 @@

 import os.path

-__version__ = "7.4.2"
+__version__ = "8.0.0"

--- setup.cfg
+++ setup.cfg
@@ -29,7 +29,7 @@
 github_repo = readthedocs.org

 [bumpver]
-current_version = "7.4.2"
+current_version = "8.0.0"
 version_pattern = "MAJOR.MINOR.PATCH[TAGNUM]"
 commit_message = "Bump version {old_version} -> {new_version}"
 commit = False

This is directly called from ops/deploy, so usage of this tool is
abstracted and not super important.

It's easy to use however, and has a string input method, instead of
incrementing each part individually, a la bump2version.

```
% bumpver update --dry --set-version "8.0.0"
INFO    - fetching tags from remote (to turn off use: -n / --no-fetch)
INFO    - Old Version: 7.4.2
INFO    - New Version: 8.0.0
--- docs/conf.py
+++ docs/conf.py
@@ -67,7 +67,7 @@
 copyright = '2010-{}, Read the Docs, Inc & contributors'.format(
     timezone.now().year
 )
-version = "7.4.2"
+version = "8.0.0"
 release = version
 exclude_patterns = ['_build']
 default_role = 'obj'
--- package.json
+++ package.json
@@ -1,6 +1,6 @@
 {
   "name": "readthedocs",
-  "version": "7.4.2",
+  "version": "8.0.0",
   "description": "Read the Docs build dependencies",
   "author": "Read the Docs, Inc <[email protected]>",
   "scripts": {
--- readthedocs/__init__.py
+++ readthedocs/__init__.py
@@ -2,5 +2,5 @@

 import os.path

-__version__ = "7.4.2"
+__version__ = "8.0.0"

--- setup.cfg
+++ setup.cfg
@@ -29,7 +29,7 @@
 github_repo = readthedocs.org

 [bumpver]
-current_version = "7.4.2"
+current_version = "8.0.0"
 version_pattern = "MAJOR.MINOR.PATCH[TAGNUM]"
 commit_message = "Bump version {old_version} -> {new_version}"
 commit = False
```
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a cleaner approach. I'm 👍 assuming we integrate it in our deploy scripts.

@agjohnson agjohnson merged commit 007f542 into main Mar 22, 2022
@agjohnson agjohnson deleted the agj/bumpver branch March 22, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants