Skip to content

Sync versions: filter by type on update #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Sync versions: filter by type on update #9019

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30ad791
Sync versions: filter by type on update
stsewd Mar 15, 2022
12b5889
Add test
stsewd Mar 16, 2022
6aeb748
Merge branch 'main' into filter-by-type-on-update
stsewd Mar 29, 2022
7205620
Don't use the origin/ part for branches
stsewd Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/api/v2/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ def sync_versions_to_db(project, versions, type): # pylint: disable=redefined-b
Version.objects.filter(
project=project,
verbose_name=version_name,
type=type,
).update(
identifier=version_id,
type=type,
machine=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to explain with a comment in code the situation described in the description of the PR.

)

Expand Down