Build: use same build environment for setup and build #9018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't do `with self.build_environment:` twice because the context manager kills the Docker container on `__exit__`. So, the second time we call the `with` it will create a new container which won't have all the work done in the previous steps. We could avoid this by using shared volumes instead, but that's a bigger refactor. For now, I'm moving the part that creates the build environment back to the Celery task and executing `setup_environment` _and_ `build` steps from there, which is not ideally, but solves the problem for now.
ericholscher
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't do
with self.build_environment:twice because the context managerkills the Docker container on
__exit__. So, the second time we call thewithit will create a new container which won't have all the work done in the
previous steps.
We could avoid this by using shared volumes instead, but that's a bigger
refactor. For now, I'm moving the part that creates the build environment back
to the Celery task and executing
setup_environmentandbuildsteps fromthere, which is not ideally, but solves the problem for now.
This problem was introduced in #9002