Git: fix annotated tags on lsremote #9017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a tag is annotated,
the real commit will be on the ref that ends with `^{}`.
GitPython handles this correctly,
but lsremote was returning the sha of the tag instead of the commit.
We are using GitPython to get the tags when doing a full build,
and lsremote when doing a sync.
This mismatch is causing problems, as rtd will take it as if the tags
were updated.
humitos
reviewed
Mar 16, 2022
There is already a test case for that in this PR |
|
Is this deployed already? It's not added to any GH project. After we deploy this, we should re-enable lsremote feature flag for all the projects. |
We need #9019 as well before that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tag is annotated,
the real commit will be on the ref that ends with
^{}.GitPython handles this correctly,
but lsremote was returning the sha of the tag instead of the commit.
We are using GitPython to get the tags when doing a full build,
and lsremote when doing a sync.
This mismatch is causing problems, as rtd will take it as if the tags
were updated.
Fixes #8992