Build: RepositoryError message
#8999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `RepositoryError` _without_ a message was raised we were setting the message as `"None"` and reporting this to the user :( This commit first checks if the exception already contains a message and use it in that case. If the exception does not contains a message, it raises it without a message so the generic one is added by the Celery handler (`on_failure`). Also, it improves the messages reported to the user to communicate a more detailed error depending the case.
humitos
force-pushed
the
humitos/repository-error-message
branch
from
64099d1 to
3994cb7
Compare
agjohnson
reviewed
Mar 7, 2022
|
There is a failing lint test that I'll try fixing for this PR to get it merged. |
agjohnson
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
RepositoryErrorwithout a message was raised we were setting themessage as
"None"and reporting this to the user :(This commit first checks if the exception already contains a message and use
it in that case. If the exception does not contains a message, it raises it
without a message so the generic one is added by the Celery
handler (
on_failure).Also, it improves the messages reported to the user to communicate a more
detailed error depending the case.
Related to the error reported in #8995