Skip to content

Celery: increase timeout limit for sync_remote_repositories task #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 28, 2022

Users belonging to huge GH organizations, like conda-forge, were never syncing
their repositories because the task timed out and none of the relationships were
created.

@humitos humitos requested a review from agjohnson February 28, 2022 11:56
@humitos humitos requested a review from a team as a code owner February 28, 2022 11:56
@humitos
Copy link
Member Author

humitos commented Feb 28, 2022

We are 100% sure we have a problem with conda-forge, so we could hardcode this name and skip it from the re-sync as next step if we want. Nobody is importing conda-forge repositories into Read the Docs and I don't think it makes sense at all.

Also, showing this repositories in the UI is currently distracting to users. This will be solved in the ext-theme because we will be allowing filtering, tho.

Users belonging to huge GH organizations, like `conda-forge`, were never syncing
their repositories because the task timed out and none of the relationships were
created.
@humitos humitos force-pushed the humitos/timeout-celery-task-oauth-sync branch from 91121de to 8d47634 Compare February 28, 2022 12:19
@agjohnson
Copy link
Contributor

we could hardcode this name and skip it from the re-sync as next step if we want

This sounds like a great idea. If we felt it was necessary to show the conda-forge organization in the import page, we might just want to skip tracking repositories in the conda forge organization (still keeping the conda-forge organization relationship to the github connected user). We could at least show this organization in a disabled and skipped state.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix as a temporary solution 👍 We should follow up to this and skip tracking conda-forge repos at all though -- agreed it doesn't make sense to show these.

@humitos humitos merged commit 7a92182 into master Mar 1, 2022
@humitos humitos deleted the humitos/timeout-celery-task-oauth-sync branch March 1, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants