Skip to content

Django3: use new JSON fields instead of old TextFields #8934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 17, 2022

This is the continuation of the work done in #8926

This PR will remove old fields and rename new fields with the old names. After the deploy, instances will be using the new fields.

@humitos humitos requested a review from a team as a code owner February 17, 2022 14:07
@stsewd
Copy link
Member

stsewd commented Feb 17, 2022

You should be able to remove the save() overrides in this PR, but then the migration will need to run before deploying the webs to avoid data loss.

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be fixed

@humitos humitos enabled auto-merge February 21, 2022 13:43
@humitos humitos force-pushed the humitos/django3-json-fields branch 2 times, most recently from f0e610c to e03c2ec Compare February 21, 2022 14:48
@humitos humitos force-pushed the humitos/django3-json-fields branch from e03c2ec to 9842783 Compare February 21, 2022 15:42
@humitos humitos merged commit 4e378db into master Feb 21, 2022
@humitos humitos deleted the humitos/django3-json-fields branch February 21, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants