CI: Don't install debug tools when running tests #8882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip is freezing when installing ipdb, but we also shouldn't install these in our CI. Installing them from a separate file fixes the issues with pip's dependency resolver.
stsewd
commented
Feb 2, 2022
|
|
||
| # jedi 0.18 is incompatible with ipython | ||
| # https://github.com/ipython/ipython/issues/12740 | ||
| jedi>0.17,<0.18 # pyup: ignore |
There was a problem hiding this comment.
this problem was already fixed in the latest version we install
|
Now circle doesn't want to run the jobs for this branch, is like it doesn't want us to fix the problem :D |
ericholscher
approved these changes
Feb 2, 2022
| deps = -r{toxinidir}/requirements/testing.txt | ||
| deps = | ||
| -r{toxinidir}/requirements/testing.txt | ||
| debug: -r{toxinidir}/requirements/debug.txt |
There was a problem hiding this comment.
Didn't know about this syntax.
|
|
||
| The ``tox`` configuration has the following environments configured. You can | ||
| target a single environment to limit the test suite: | ||
|
|
||
| py38 | ||
| Run our test suite using Python 3.8 | ||
|
|
||
| py38-debug | ||
| Same as ``py38``, but there are some useful debugging tools available in the environment. |
There was a problem hiding this comment.
Is it worth defining what is installed? Or maybe linking to the file? Not necessary though.
humitos
approved these changes
Feb 3, 2022
|
Do we plan to keep this solution or we plan to rever it once pip's problem is solved? |
Hmm good question, we discussed with Eric that it was weird that we install debug tools in our CI, but I see this also adding some complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip is freezing when installing ipdb,
but we also shouldn't install these in our CI.
Installing them from a separate file fixes the issues
with pip's dependency resolver.