Skip to content

Version should be in quotes #8857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

askpatrickw
Copy link

Just like the one in this repo. ;-)

Just like the one in this repo. ;-)
@askpatrickw askpatrickw requested a review from a team as a code owner January 28, 2022 00:15
@humitos
Copy link
Member

humitos commented Jan 28, 2022

Hi! Thanks for these changes.

I noted these changes are for the V1 of the config file, which in not sure if works with the Python version as string. cc @stsewd

Actually, I'd say we should remove everything related to config V1 from our documentation to avoid confusion and start deprecating it. @ericholscher what do you think?

@askpatrickw
Copy link
Author

askpatrickw commented Jan 28, 2022

Sorry, I missed that it was a versioned format. In the V2 docs, I think you still need to add the quotes.

Of course the next question is, why does it have to be in quotes and why doesn't build.os? ;-)

@agjohnson
Copy link
Contributor

We discussed removal and options a bit at #8648

@humitos
Copy link
Member

humitos commented Feb 1, 2022

Of course the next question is, why does it have to be in quotes and why doesn't build.os? ;-)

This is to avoid float numbers confusion on Python version. If you use python.version: 3.10 in the config file, that will be interpreted as 3.1, but "3.10" will be 3.10. build.os does not have this problem.

@ericholscher
Copy link
Member

@humitos 👍 on removing config v1, or at least removing it from the toctree/navigation.

@askpatrickw
Copy link
Author

Doesn't sound like this PR is going to move forward, closing.

@askpatrickw askpatrickw closed this Feb 3, 2022
@askpatrickw askpatrickw deleted the patch-1 branch February 3, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants