-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update choosing a platform doc #8837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
agjohnson
commented
Jan 25, 2022
- Unify on "site" -> "platform"
- Remove some words for clarity and brevity
- Add some more marketing content, commercial section was dry
a52880a
to
095837e
Compare
* Unify on "site" -> "platform" * Remove some words for clarity and brevity * Add some more marketing content, commercial section was dry
docs/user/choosing-a-site.rst
Outdated
This is great for user and developer documentation for your project. | ||
|org_brand| is strictly for hosting open source documentation. This means that | ||
project documentation source, and the generated documentation, are both publicly | ||
accessible and licensed under a permissive license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why permissive specifically? Could be copyleft as well (not considered "permissive" as far as I understand). Or, not have a license at all, because people tend to forget to choose a license. I would remove references to the licensing here, just say that the sources are "publicly visible" or something like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, I don't think we mention any of that in our ToS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points.
I wasn't meaning to differentiate between copyleft and permissive here. There's no point where we check or enforce licensing, however we do describe in several places (or have described in the past) that community is for open source projects or non-commercial works. Dropping mention of a license is the most correct though.
True about repositories without a license. Github TOS would apply here by default, meaning those repositories retain full copyright and do not explicitly grant us any rights at all -- even the right "to use".
In this case, our TOS does grant us necessary rights:
https://docs.readthedocs.io/en/stable/terms-of-service.html#license-grant-to-us
So, open licensing is not a legal requirement because our TOS works around that. But, I will leave the mention of open source documentation hosting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for one thing, left a comment
* Don't mention licenses at all, this isn't a legal or technical req * Strictly sounded odd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!