Skip to content

Bitbucket: update to match latest API changes #8801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 10, 2022

Note that "Filter repositories" now will show "username" (humitos) and
"workspace name" (Manuel Kaufmann) which are duplicated. The first one,
humitos, will not show any repository when clicked because all repositories
belong to a workspace now (mapped as RemoteOrganization for us)

Along those lines, repositories, projects and snippets will no longer have an owner. They will be located within a workspace

We may want to come back to this later and remove the "personal account filter"
from the "Filter repositories" list only for the Bitbucket case.

Screenshot_2022-01-10_11-29-58

(in the image, humitos is my personal user and Manuel Kaufmann is the workspace for my own account)

* https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-teams-deprecation/
* https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-workspaces/

Note that "Filter repositories" now will show "username" (`humitos`) and
"workspace name" (`Manuel Kaufmann`) which are duplicated. The first one,
`humitos`, will not show any repository when clicked because all repositories
belong to a workspace now (mapped as `RemoteOrganization` for us)

We may want to come back to this later and remove the "personal account filter"
from the "Filter repositories" list _only_ for the Bitbucket case.
@humitos humitos requested a review from a team January 10, 2022 10:34
@humitos
Copy link
Member Author

humitos commented Jan 10, 2022

The checks error is not related to this PR:

projects/views/private.py
  Line: 287
    pylint: arguments-differ / Parameters differ from overridden 'post' method (col 4)

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, though I also am not familiar with the team -> workspace change on the Bitbucket side. Seems simple enough though.

@ericholscher
Copy link
Member

Agreed, lets get this out 👍

@ericholscher
Copy link
Member

Tested are broken in master, so merging.

@ericholscher ericholscher merged commit 5aa0530 into master Jan 10, 2022
@ericholscher ericholscher deleted the humitos/bitbucket-api-changes branch January 10, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants