Skip to content

Requirements: downgrade celery #8796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Requirements: downgrade celery #8796

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c478dd
Requirements: downgrade celery
humitos Jan 4, 2022
05735d9
Merge branch 'master' into humitos/hotfix/downgrade-celery
humitos Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions requirements/pip.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,17 @@ slumber==0.7.1
pyyaml==5.4.1 # pyup: ignore
Pygments==2.10.0

# Basic tools

# Downgrade redis to 3.5.3 (latest 3.x release) because pip raises this error:
# django-redis-cache 2.1.3 depends on redis<4.0
redis==3.5.3 # pyup: ignore

kombu==5.2.2
celery==5.2.2
# Pin celery and kombu because it produces an error
# File "/home/docs/lib/python3.8/site-packages/celery/app/trace.py", line 361, in build_tracer
# push_request = request_stack.push
# AttributeError: 'NoneType' object has no attribute 'push'
# See https://github.com/celery/celery/discussions/7172
kombu==5.1.0 # pyup: ignore
celery==5.1.2 # pyup: ignore
Comment on lines +41 to +43
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From that post, it seems that task.register() is not enough now. We may need to dig a little more on this to figure it out what's happening.

We are registering tasks in that way here, for example:

readthedocs.org/readthedocs/builds/apps.py

Lines 26 to 29 in d6db011

app.tasks.register(Metrics1mTask)
app.tasks.register(Metrics5mTask)
app.tasks.register(Metrics10mTask)
app.tasks.register(Metrics30mTask)


# When upgrading to 0.43.0 we should double check the ``base.html`` change
# described in the changelog. In previous versions, the allauth app included a
Expand Down