Spam: deny dashboard on spammy projects #8792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/spam-deny-dashboard
branch
3 times, most recently
from
ac14ca6 to
aff3673
Compare
Quick/Initial implementation to deny showing a project's dashboard if spam score
is above the threshold.
- the old and non-used `ProjectSpamError` that checked for an invalid
description was removed together with all its logic
- the mixin `ProjectSpamMixin` was re-purposed to check the spam score and deny
serving the dashboard
- move "disable banned user to import projects" inside the `ImportWizardView`
Note that currently we are only denying the dashboard for the project's
detail ("Overview" in our UI) view. If we want to deny other pages like
"Downloads", "Search", "Builds", "Versions" and "Admin" we need to adapt other
views as well (e.g. migrate them from function-based view to class-based view to
be able to re-use the mixin). This can be implemented in a future version.
Together with this, we could only deny the dashboard to non-maintainers of the
project itself, allowing them to make some changes in case of a mistake.
humitos
force-pushed
the
humitos/spam-deny-dashboard
branch
from
aff3673 to
730b0fd
Compare
ericholscher
approved these changes
Jan 4, 2022
| # django-textclassifier doesn't have pinned versions | ||
| # if there is an update they could break our code | ||
| nltk==3.6.6 | ||
| textblob==0.17.1 |
There was a problem hiding this comment.
These are big dependencies, so 👍 on getting rid of them if we aren't using them.
| days=settings.USER_MATURITY_DAYS | ||
| ) | ||
| if request.user.date_joined > date_maturity: | ||
| request.user.profile.banned = True |
There was a problem hiding this comment.
So we will only have banned users manually now, correct? That seems fine.
There was a problem hiding this comment.
Yes. I didn't know about this code and I was surprised when I saw it yesterday. I think it wasn't working, tho. We can get back to "auto ban" in the future if we find a reliable way of doing it.
|
I would like to see us remove all the dashboard views, but the detail is definitely the big one for now. Let's see how this effects things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick/Initial implementation to deny showing a project's dashboard if spam score
is above the threshold.
ProjectSpamErrorthat checked for an invaliddescription was removed together with all its logic
ProjectSpamMixinwas re-purposed to check the spam score and denyserving the dashboard
ImportWizardViewNote that currently we are only denying the dashboard for the project's
detail ("Overview" in our UI) view. If we want to deny other pages like
"Downloads", "Search", "Builds", "Versions" and "Admin" we need to adapt other
views as well (e.g. migrate them from function-based view to class-based view to
be able to re-use the mixin). This can be implemented in a future version.
Together with this, we could only deny the dashboard to non-maintainers of the
project itself, allowing them to make some changes in case of a mistake.