Spam: allow to mark a project as (non)spam manually #8779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is used from readthedocs-ext to always return 0 as score when the project was manually marked as `is_spam=False`. This way, even if there are some `SpamRule`s that apply to the project, we can manually tell our system that this project is valid and remove false positives. See readthedocs/readthedocs-ext#458
|
There is a doc warning that makes the checks to fail, but it's unrelated to this PR. |
stsewd
reviewed
Jan 3, 2022
| @@ -306,6 +306,11 @@ class Project(models.Model): | |||
| default=False, | |||
| help_text='If checked, do not show advertising for this project', | |||
| ) | |||
| is_spam = models.NullBooleanField( | |||
There was a problem hiding this comment.
In https://github.com/readthedocs/readthedocs.org/pull/8717/files#diff-2026582e018afc479271c2c856ebf5163912b778923ab381526f03d3aa2363a3 you are replacing NullBoolean fields with a boolean field that accepts null values, probably better to use a boolean field here.
There was a problem hiding this comment.
Agreed, this seems useful 👍
ericholscher
requested changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is used from readthedocs-ext to always return 0 as score when the
project was manually marked as
is_spam=False. This way, even if there are someSpamRules that apply to the project, we can manually tell our system that thisproject is valid and remove false positives.
See https://github.com/readthedocs/readthedocs-ext/issues/458