Skip to content

Docs: split user and dev docs #8751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 20, 2021
Merged

Docs: split user and dev docs #8751

merged 10 commits into from
Dec 20, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 8, 2021

This splits the docs in two, one set container user-facing documentation, and the other one containing development documentation. The structure is like

  • docs
    • user
      • _static (per-docset files)
    • dev
    • conf.py (shared config)
    • _static (shared files)

The user facing docs will be served from https://docs.readthedocs.io/ (just as they are today), and the dev docs will be served from https://dev.readthedocs.io/.

To build each docset you need to set the RTD_DOCSET env var (defaults to the user documentation), docs have been updated to mention this, there is also some explanation on the conf.py file.

I'm not really sure what will happen with the localization strings (I left them in the docs/user dir)

@stsewd stsewd force-pushed the separate-dev-docs branch from 5ad9935 to efb0714 Compare December 8, 2021 03:57
@astrojuanlu
Copy link
Contributor

If I understand correctly, a single .readthedocs.yaml and docs/conf.py files would be used for 2 different Read the Docs projects? Smart 🧠

@stsewd stsewd closed this Dec 8, 2021
@stsewd stsewd reopened this Dec 8, 2021
@stsewd stsewd closed this Dec 8, 2021
@stsewd stsewd reopened this Dec 8, 2021
@stsewd
Copy link
Member Author

stsewd commented Dec 8, 2021

If I understand correctly, a single .readthedocs.yaml and docs/conf.py files would be used for 2 different Read the Docs projects? Smart brain

yeah, hopefully in the future we can use individual rtd config files (mostly to have different search ranking/ignore for each one). This was Anthony's idea actually :D

Test are failing because https://dev.readthedocs.io/en/stable/ has the contents from master instead of the new content, it will have the new content after this PR is merged (and we push a tag, since intersphinx is pointing to "stable", could also point it to latest till we do another release).

Previews at:

Redirects are in place.

@stsewd stsewd marked this pull request as ready for review December 8, 2021 22:12
@stsewd stsewd requested review from a team as code owners December 8, 2021 22:12
@stsewd stsewd requested review from agjohnson and removed request for a team December 8, 2021 22:12
@@ -66,6 +96,8 @@ def get_version():
'jupyterbook': ('https://jupyterbook.org/', None),
'myst-parser': ('https://myst-parser.readthedocs.io/en/v0.15.1/', None),
'rst-to-myst': ('https://rst-to-myst.readthedocs.io/en/stable/', None),
'rtd': ('https://docs.readthedocs.io/en/stable/', None),
'rtd-dev': ('https://dev.readthedocs.io/en/stable/', None),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally I'm testing this with

Suggested change
'rtd-dev': ('https://dev.readthedocs.io/en/stable/', None),
'rtd-dev': ('https://dev.readthedocs.io/en/separate-dev-docs/', None),

@astrojuanlu
Copy link
Contributor

Minor thing: is there a chance we could tweak the theme a bit to give these docs a distinct visual identity? Something like:

Screenshot 2021-12-09 at 03-13-33 Read the Docs developer documentation — Read the Docs developer documentation 6 3 0 docum

(#888 for the bg, #bbb for .wy-side-nav-search input[type="text"] { border-color }, #888 for headings)

@stsewd
Copy link
Member Author

stsewd commented Dec 9, 2021

@astrojuanlu we could do that, I was also thinking we could have a different logo. We may need help from @readthedocs/frontend for these visual changes :)

Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a brief look and it all looks correct. I think it's easier to merge and then fix whatever breaks, since it will keep having conflicts all the time.

I will try to take care of this PR next week.

@ericholscher
Copy link
Member

Agreed, this looks good to me, so lets move forward with it. The redirects are the main thing.

@astrojuanlu
Copy link
Contributor

Merging, and fixing tests later 👍

@astrojuanlu astrojuanlu merged commit cf38507 into master Dec 20, 2021
@astrojuanlu astrojuanlu deleted the separate-dev-docs branch December 20, 2021 12:35
@astrojuanlu
Copy link
Contributor

Looks like @stsewd already created the redirects, and they're working 🎉
Screenshot from 2021-12-20 07-50-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants