Break out commits for review. #8729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log success requests using `django-structlog` and send them New Relic to know what projects are using EmbedAPI, if they are using sphinx-hoverxref and what version of it. This is the minimum configuration required to start using structlog + New Relic. If we are happy with the results we can migrate the other logs to structlog, which should be simple, but a little tedious to do search&replace. In the future, we can also set up django-structlog to log Celery tasks as well.
Use structlog _only_ for EmbedAPI v2/v3 for now. We will do a test in production to this and decide the migration path for the whole codebase.
|
Can't review a PR I set up, but changes look good to merge 👍 This was mostly scaffolding for structlog, so I don't have too much input on the code here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a sub-PR merge, review was difficult on #8689. This is the two commits,
isolated.
This should be merged to master first, and then we'll need to figure out how to
remerge commits from #8705.