requirements: use django-cors-headers instead #8713
Conversation
humitos
force-pushed
the
humitos/django-cors-requirement
branch
from
4d149d8 to
f678e83
Compare
requirements/pip.txt
Outdated
| @@ -92,9 +92,10 @@ dj-pagination==2.5.0 | |||
| # Version comparison stuff | |||
| packaging==21.2 | |||
|
|
|||
| # django-cors-middleware==1.5.0 fails with | |||
| # django-cors-middleware was replaced by django-cors-headers | |||
| # django-cors-headers==3.10.0 is failing with: | |||
There was a problem hiding this comment.
Should we not fix the error if we're looking to upgrade this package? This feels like a sideways move, but not really what we need to do to move forward?
There was a problem hiding this comment.
I don't think we can fix this issue by ourselves. I didn't research too much yet, but I found adamchainz/django-cors-headers#558 that it's related to a Django bug which is solved in 3.1.x
There was a problem hiding this comment.
@humitos I believe we're on a newer Django now, so is this fixed?
There was a problem hiding this comment.
Let's see. I've rebased the branch and push. Tests should pass now if it's fixed 😄
There was a problem hiding this comment.
It seems it's not fixed yet... Tests are still failing, :/
|
Bumping this one off our release tomorrow due to questions here. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
Status: stale
humitos
force-pushed
the
humitos/django-cors-requirement
branch
from
976e942 to
ed2469c
Compare
|
The issue |
|
This seems like it will get bumped out a release. I won't reassign a release yet though, sounds like this one is a bit more elusive than we expected. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
Status: stale
Note that `django-cors-middleware` is deprecated (see note in https://github.com/zestedesavoir/django-cors-middleware) and they recommend using `django-cors-headers` instead.
We are using Django 3.x now, so this problem should be solved now.
humitos
force-pushed
the
humitos/django-cors-requirement
branch
from
ed2469c to
7a6ba35
Compare
|
With the latest refactor that @stsewd did in CORS, this dependency can probably be removed completely, right? |
|
@humitos nope, we still need it to set the proper CORS headers for us. |
|
@stsewd would be good to get upgraded to a supported version here, since we aren't doing anything custom anymore. 👍 |
|
I'm doing this at #10000. also, PR/issue number 10K! |
Note that
django-cors-middlewareis deprecated (see note inhttps://github.com/zestedesavoir/django-cors-middleware) and they recommend
using
django-cors-headersinstead.Related to #8692