Skip to content

Add guide on Poetry #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Add guide on Poetry #8702

merged 4 commits into from
Nov 23, 2021

Conversation

astrojuanlu
Copy link
Contributor

Clarifies how Poetry is supported on Read the Docs.

@astrojuanlu astrojuanlu requested a review from a team as a code owner November 22, 2021 22:16
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There maybe there isn't really anything substantial here, but maybe we want to mention how to verify that the dependencies are being used? This guide goes to mention pinning and the lock file, but might leave the reader guessing how to wrap this process up.

@astrojuanlu
Copy link
Contributor Author

@astrojuanlu astrojuanlu mentioned this pull request Nov 23, 2021
@astrojuanlu
Copy link
Contributor Author

There maybe there isn't really anything substantial here,

Yep, it ended up being quite short. At least now "poetry" returns something in the search.

but maybe we want to mention how to verify that the dependencies are being used? This guide goes to mention pinning and the lock file, but might leave the reader guessing how to wrap this process up.

Opened #8704 to track this discussion in a more general way, so it's useful for other pages as well.

@astrojuanlu astrojuanlu merged commit ecda33f into master Nov 23, 2021
@astrojuanlu astrojuanlu deleted the poetry-guide branch November 23, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants