Downgrade celery and friends #8693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They break the local installation, and looks like some minor versions were released yesterday for both, kombu and redis. https://docs.celeryproject.org/en/latest/changelog.html
humitos
reviewed
Nov 17, 2021
Comment on lines
+34
to
+35
| kombu==5.1.0 | ||
| celery==5.1.2 |
There was a problem hiding this comment.
Can you add a comment here saying how and why it breaks and ignore it by pyup for now?
There was a problem hiding this comment.
I think it's fine to try to upgrade next week, after the deploy. Didn't test if the patch version they released fixed the problem.
There was a problem hiding this comment.
We hit this problem today in production 😞 --we should have added the comment with the error and ignored it by pyup 👍🏼 . See #8796
|
We need this for release, this is only reverting a change, so nothing breaking. We should test the new release of celery before updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They break the local installation,
and looks like some minor versions
were released yesterday for both, kombu and redis.
https://docs.celeryproject.org/en/latest/changelog.html