Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document generic webhooks #8609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document generic webhooks #8609
Changes from 19 commits
c0689f1
c6c499b
0a031b3
9405d4b
2dd6b39
3e988a5
80446dd
ce31189
43f9dd4
b6fd66e
b443b4f
8f55e27
39c8ab2
fe45d31
33f9557
1077d61
481380d
19eec46
088e629
2a0a031
ec9b4fc
b049047
94f9fc1
a928097
8f20472
04e2953
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like bad UX. I would strongly suggest that we implement a standard
Slack webhook
option, instead of forcing users to copy & paste large bits of JSON into our dashboard. /cc @stsewdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this be an option to pre-fill the content, or just an option where users don't have control over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this for automation rules for example
But I'd prefer the option to pre-fill the content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and user would still need to setup webhook from their side on slack/discord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stsewd I think something that we control should be the default. Many users don't actually want to think about this, and having something that we control and can improve over time without users having to touch it feels like better UX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the same fashion, imagine that Slack changed their webhook format or something. It would be a huge pain if we had to email every user to ask them to update the blob of JSON in the config. We should definitely support "Slack" as a first-class option that we control the format of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if that happens slack will provide users a different url or option, then we are forced to support both formats using an option or something.
My other worry here is if we change something, it will affect everyone, users may not like something from the new change and will request for options, and we end up adding a lot of options in the UI or the users will end up creating their own custom payload at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stsewd Valid concerns, but I think there are a large number of users who just want "Slack notifications" that work well. Asking them to customize them is an actively negative experience. I think we want both the simple & custom, so users can choose what works better for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should maybe start each section with the links to the docs to create the webhhok on slack/discord and then give them the payload to use (Follow this steps on discord/slack, use the given URL when creating a webhook on rtd and add this payload).