Skip to content

EmbedAPIv3: docs for endpoint and guide updated #8566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 6, 2021

@humitos humitos requested review from astrojuanlu and a team October 6, 2021 12:02
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start 👍

docs/api/v3.rst Outdated
:>json string external: whether or not the page is hosted on Read the Docs or externally.

:query string url: full URL of the document (with optional fragment) to fetch content from.
:query string doctool: *optional* documentation tool key name used to generate the target documentation (e.g. ``sphinx``)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a list of supported tools?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not officially, I'd say. However, all the tools that Read the Docs supports should be listed here: sphinx and mkdocs. That said, we are only doing special treatment for sphinx at this moment.

@humitos
Copy link
Member Author

humitos commented Oct 13, 2021

@ericholscher I made some small updates to address your feedback.

@ericholscher
Copy link
Member

@humitos Looks good when link goes green 👍

@astrojuanlu
Copy link
Contributor

The failed checks are some broken links in our docs. I'll address those separately.

@humitos humitos disabled auto-merge October 14, 2021 08:46
@humitos humitos merged commit 08af341 into master Oct 14, 2021
@humitos humitos deleted the humitos/embed-api-v3-docs branch October 14, 2021 08:46
@astrojuanlu
Copy link
Contributor

(Some were addressed by #8584)

.. http:get:: /api/v3/embed/

Retrieve HTML-formatted content from documentation page or section.
Read :doc:`guides/embedding-content` to know more about how to use this endpoint.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be, that's breaking our CI

:doc:`/guides/embedding-content

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, addressing in #8586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants