-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
EmbedAPIv3: docs for endpoint and guide updated #8566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start 👍
docs/api/v3.rst
Outdated
:>json string external: whether or not the page is hosted on Read the Docs or externally. | ||
|
||
:query string url: full URL of the document (with optional fragment) to fetch content from. | ||
:query string doctool: *optional* documentation tool key name used to generate the target documentation (e.g. ``sphinx``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a list of supported tools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not officially, I'd say. However, all the tools that Read the Docs supports should be listed here: sphinx
and mkdocs
. That said, we are only doing special treatment for sphinx
at this moment.
Co-authored-by: Eric Holscher <[email protected]>
@ericholscher I made some small updates to address your feedback. |
@humitos Looks good when link goes green 👍 |
The failed checks are some broken links in our docs. I'll address those separately. |
(Some were addressed by #8584) |
.. http:get:: /api/v3/embed/ | ||
|
||
Retrieve HTML-formatted content from documentation page or section. | ||
Read :doc:`guides/embedding-content` to know more about how to use this endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be, that's breaking our CI
:doc:`/guides/embedding-content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, addressing in #8586
api/v3.rst
(https://docs--8566.org.readthedocs.build/en/8566/api/v3.html#embed)