Skip to content

EmbedAPI: allow CORS for /api/v3/embed/ #8543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021
Merged

EmbedAPI: allow CORS for /api/v3/embed/ #8543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions readthedocs/core/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
'/api/v2/search',
'/api/v2/docsearch',
'/api/v2/embed',
'/api/v3/embed',
]

webhook_github = Signal(providing_args=['project', 'data', 'event'])
Expand Down Expand Up @@ -76,6 +77,12 @@ def decide_if_cors(sender, request, **kwargs): # pylint: disable=unused-argumen
url = request.GET.get('url')
if url:
unresolved = unresolve(url)
if unresolved is None:
# NOTE: Embed APIv3 now supports external sites. In that case
# ``unresolve()`` will return None and we want to allow it
# since the target is a public project.
return True

project = unresolved.project
version_slug = unresolved.version_slug
else:
Expand Down