Skip to content

Requirement: ping django-redis-cache to git tag #8536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 28, 2021

For some reason django-redis-cache==2.1.3 breaks with:

@get_client(write=True)
def get_or_set(self, client, key, func, timeout=DEFAULT_TIMEOUT):
    if not callable(func):
        raise Exception("Must pass in a callable")

Looks like an older version gets installed somehow that does not contains the
code we need. So, we force it to be pinned to a git tag.

For some reason django-redis-cache==2.1.3 breaks with:

@get_client(write=True)
def get_or_set(self, client, key, func, timeout=DEFAULT_TIMEOUT):
    if not callable(func):
        raise Exception("Must pass in a callable")

Looks like an older version gets installed somehow that does not contains the
code we need. So, we force it to be pinned to a git tag.
@humitos humitos requested a review from a team September 28, 2021 15:50
@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Sep 28, 2021
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly, but it works 🤷

@humitos humitos merged commit 9575a28 into master Sep 29, 2021
@humitos humitos deleted the humitos/pin-django-redis branch September 29, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants