-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Promote and restructure guides #8528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e33ef7
to
037a15b
Compare
Rendered result: https://docs--8528.org.readthedocs.build/en/8528/#how-to-guides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a 💯 refactor. I love this structure of the guides -- much more intuitive and valuable.
I would like to perhaps use this as an opportunity to clean up some of the titles on the pages, if possible. I see you already did a couple, but I think there's a lot more room here to clarify them (and make them better for SEO).
I'd also love to figure out a core set of features that we care about, and promote/document effectively. I feel like we're slowly getting to that point, but we should really discuss and have it defined somewhere (and very obviously highlighted on the website/marketing pages/docs).
A couple questions for moving forward:
- How do we distinguish .com content? Perhaps an emoji and a warning at the top of the guide or similar to what we do for sphinx-only content?
- I feel like the
First steps
&Getting started
sections are a bit muddled (especially since the first steps containgetting started
docs). I think we can work to clean this up a bit. Perhaps renameGetting started
section toPlatform Overview
orFeature Documentation
orPrimary Features
? We already haveAdvanced Features
, so maybe it makes sense to differentiate it from that?
@@ -0,0 +1,18 @@ | |||
Guides for documentation authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much better way to think about the guide structure 💯
* :doc:`/guides/tools` | ||
* :doc:`/guides/platform` | ||
* :doc:`/guides/commercial` | ||
* **For documentation authors**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shows we need more of these guides 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double yes: we need more guides, and some of the current ones should probably be moved to Sphinx...
Co-authored-by: Eric Holscher <[email protected]>
Thanks for the thorough feedback @ericholscher . On your questions:
I was precisely thinking of an emoji. And rather than a warning, a custom-colored admonition?
Totally agree. Will review this now. |
Opened #8535 about the first part. Hope to tackle that in a future iteration. |
15c3075
to
e3a8ed5
Compare
e3a8ed5
to
30b7ce2
Compare
I'm done with the first round of review - @ericholscher I see that you approved, but I have made some significant changes since, so I'm asking for another review just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- really excited for the docs to keep improving 💯
@@ -1,7 +1,7 @@ | |||
Analytics | |||
--------- | |||
Traffic Analytics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Matching the UI is a good place to start. I could see moving to something like:
Traffic Analytics | |
Traffic Analytics - See top performing doc pages |
In the future, but we'd need to change up how we're linking to them. Perhaps adding a subhead of some kind would be another way to handle this.
Thanks a lot! Opened #8537 to focus on SEO. |
I agree that the vertical separators are not very nice, and I think we have discussed about removing them. However, a stated non-goal of this PR was to not "Evolve the visual aspect of our documentation", so I kept consistency to what we have now to avoid derailing the discussion. @nienn proposed some cool ideas in #8513, but I think we first need to think through the structure of all our docs. As @ericholscher said above,
|
See discussion at #8321. After extensive discussion, I approached this with several goals in mind:
And, in addition, I had some non-goals:
I ended up doing these four things:
I think these categories make it more explicit what is the audience of each document, although there are some grey areas of course.
Also, for the index, I picked the most popular guides, and for the rest, I added an "others" link to not overwhelm (more) the readers.