New config for new docker build images #8478
Conversation
stsewd
force-pushed
the
docker-image-config
branch
7 times, most recently
from
013e943 to
4b4cdb1
Compare
stsewd
force-pushed
the
docker-image-config
branch
from
4b4cdb1 to
4251717
Compare
| # Always point to the latest stable release. | ||
| RTD_DOCKER_BUILD_SETTINGS['tools']['python']['3'] = RTD_DOCKER_BUILD_SETTINGS['tools']['python']['3.9'] | ||
|
|
There was a problem hiding this comment.
If we want to offer this as a feature, we should document it as well. Otherwise, build specifying python: 3 may start failing once we upgrade to 3.10 and will blame us.
There was a problem hiding this comment.
I added it because a couple of users wanted this feature back, we changed it to be pinned to a specific version, but that is more confusing, as users expect it to always point to the latest version available on purpose.
Co-authored-by: Manuel Kaufmann <[email protected]>
| '3.9': '3.9.7', | ||
| '3.10': '3.10.0rc2', | ||
| 'pypy3.7': 'pypy3.7-7.3.5', | ||
| 'miniconda3-4.7': 'miniconda3-4.7.12', |
There was a problem hiding this comment.
I found this problem while testing this: pyenv/pyenv#2070
I'm not sure what to do yet, one option is to patch pyenv to not install pip after installing miniconda.
There was a problem hiding this comment.
Looks good to me! As far as I can tell, all the features in the config file required to use the new Docker images are already implemented.
The only place where I'd like to have someone's else feedback is on the build.os being ubuntu20 or ubuntu-20.04 (see #8478 (comment) cc @ericholscher) because it differs from what we talked about in the document --but I don't have a strong opinion on this.
|
I see that this PR updated the |
I think we should link to the json schema, the one from yamale doesn't support a lot of things (we were using comments because of that). |
|
https://github.com/Julian/jsonschema that looks like a good implementation of json scheme in python. We could even replace part of our config validation with that. But +1 on ditching yamale, we only use it here https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/rtd_tests/tests/test_build_config.py, but we don't use anything from yamale in production which is also weird having yamale only to test the spec we don't use. |
|
Opened #8549 |
Docs need to be updated, but I'm not doing that here, since this isn't implemented yet.
Required by #8453