Skip to content

Add documentation about webhooks for Gitea #8402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2021
Merged

Add documentation about webhooks for Gitea #8402

merged 4 commits into from
Aug 16, 2021

Conversation

steko
Copy link
Contributor

@steko steko commented Aug 9, 2021

Following the fruitful discussion at #8364 I added a paragraph about setting up a webhook for Gitea projects.

Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull request @steko ! I just left a comment about a typo. I'm wondering if we should be more clear about the fact that this might be a temporary solution or workaround, waiting on someone else from the team to weigh in.

@astrojuanlu astrojuanlu requested a review from a team August 9, 2021 21:34
@humitos
Copy link
Member

humitos commented Aug 11, 2021

I'm wondering if we should be more clear about the fact that this might be a temporary solution or workaround, waiting on someone else from the team to weigh in.

Looks good to me! I'd probably add a link to the issue saying that this may be implemented at Read the Docs in the future.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left some small comments

@astrojuanlu
Copy link
Contributor

Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astrojuanlu astrojuanlu merged commit 83a5624 into readthedocs:master Aug 16, 2021

This isn't officially supported, but using the "GitHub webhook" is an effective workaround,
because Gitea uses the same payload as GitHub. The generic webhook is not compatibile with Gitea.
See `issue #8364`_ for more details. Official support may be implemented in the future.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official support may be implemented in the future.

I'm not sure that decision has been made.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"may" or "may not", I don't think this paragraph conveys any certain decision?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it gives a "false hope", I don't see us adding another service like gitea, but implementing another solution like having a more configurable webhook processing instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry the sentence sounds as a promise, it wasn't meant to be. I was trying to address this comment by @humitos. Feel free to remove it or rephrase it of course!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, this might need some input from @ericholscher or @agjohnson if we actually want to add this to our roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants