Skip to content

Fix tasks #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix tasks #8370

merged 1 commit into from
Jul 27, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jul 26, 2021

This task was deleted from common

Closes #8369

@stsewd stsewd requested a review from a team July 26, 2021 15:35
@ericholscher
Copy link
Member

Is there a way to write a test for this? Perhaps even just importing the file?

@stsewd
Copy link
Member Author

stsewd commented Jul 27, 2021

I think maybe the linter can tell if we import the tasks directly (from foo import task_name instead of import foo), let me try, if not I can try just importing the file

@astrojuanlu
Copy link
Contributor

I confirm that this closes #8369.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@humitos
Copy link
Member

humitos commented Jul 27, 2021

I'm merging this to avoid having the development instance broken. We can add the tests in another PR.

@humitos humitos merged commit cea9c3e into master Jul 27, 2021
@humitos humitos deleted the fix-tasks branch July 27, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development installation fails
4 participants