Skip to content

Schema: fix version type #8303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Schema: fix version type #8303

merged 1 commit into from
Jun 30, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 30, 2021

This should be a number,
otherwise you are required to put "2".

/cc @SethFalco

This should be a number,
otherwise you are required to put `"2"`.
@SethFalco
Copy link
Contributor

SethFalco commented Jun 30, 2021

Ahh! Sorry about that!
I thought if I used string it would accept numbers as well, or at least it did in the validator I used when I checked that.

I'll keep this in mind for future.

Edit: Just tried on Newtonsoft's site, verified you're correct.

@stsewd stsewd enabled auto-merge (squash) June 30, 2021 17:24
@stsewd stsewd merged commit 0c6ae52 into master Jun 30, 2021
@stsewd stsewd deleted the schema-fix branch June 30, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants