Skip to content

Optimize Index time database query #8224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Optimize Index time database query #8224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions readthedocs/search/documents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,5 +168,6 @@ def get_queryset(self):
queryset
.internal()
.exclude(ignore=True)
.select_related('version', 'project')
Copy link
Member Author

@saadmk11 saadmk11 Jun 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.select_related('version', 'project')
.select_related('version', 'project')
.prefetch_related(
Prefetch(
'sphinx_domains',
queryset=SphinxDomain.objects.exclude(
domain='std',
type__in=['doc', 'label']
)
)
)

We can also add prefetch_related here as well but as we are passing queryset.iterator() to .update() method of PageDocument, .prefetch_related() will be ignored. This is the same case for ProjectDocument.users as well

)
return queryset