Skip to content

Proxito: check if attribute exists #8220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021
Merged

Proxito: check if attribute exists #8220

merged 1 commit into from
May 27, 2021

Conversation

@stsewd stsewd requested a review from a team May 26, 2021 23:57
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this is happening? Did we add a new code path that isn't setting this?

@stsewd
Copy link
Member Author

stsewd commented May 27, 2021

Do we know why this is happening? Did we add a new code path that isn't setting this?

@ericholscher don't think this is new, looks like it happens when we hit this code

if (
skip
or not settings.USE_SUBDOMAIN
or 'localhost' in request.get_host()
or 'testserver' in request.get_host()
):
log.debug('Not processing Proxito middleware')
return None

So, anything with testserver or localhost in the host (https://one-testserver.readthedocs.io/) would skip setting the host_project_slug. I guess we should check if for an exact match instead of using in, or remove that check? not sure why we do that. But looks like there are other places where we could be returning early before setting the project_host_name thing.

@stsewd stsewd merged commit 4924598 into master May 27, 2021
@stsewd stsewd deleted the check-attr branch May 27, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants