Builds: prevent code injection in cwd #8198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't a vulnerability since this command is executed inside a container with a unprivileged user. I have replaced the usage of manual `cd` with using the `workdir` option from docker. This option doesn't support env vars expansion (which is safer), so I had to introduce a new setting.
stsewd
commented
May 19, 2021
stsewd
force-pushed
the
fix-code-injection-in-cwd
branch
from
b1c6d7b to
ec47d3e
Compare
humitos
approved these changes
May 20, 2021
| @@ -323,7 +323,7 @@ def setup_base(self): | |||
| # Don't use virtualenv bin that doesn't exist yet | |||
| bin_path=None, | |||
| # Don't use the project's root, some config files can interfere | |||
| cwd='$HOME', | |||
| cwd=None, | |||
There was a problem hiding this comment.
What happens when cwd= is None? Wouldn't be better to default to /tmp or similar?
There was a problem hiding this comment.
It defaults to RTD_DOCKER_WORKDIR ($HOME replacement), it can be omitted now, but didn't want to lose the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a vulnerability since this command is executed inside
a container with a unprivileged user.
I have replaced the usage of manual
cdwith using theworkdiroption from docker. This option doesn't support env vars expansion
(which is safer), so I had to introduce a new setting.
There is a PR to update usage of
$HOMEin .com