Skip to content

API v2: allow listing when using private repos #8192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 18, 2021

No description provided.

@stsewd stsewd force-pushed the allow-listing-on-priv-repos branch from 36cd60a to 08705c6 Compare May 18, 2021 19:06
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ericholscher ericholscher requested a review from humitos May 18, 2021 19:28
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine merging this if it's required for .com users. However, I'd like to keep consistency with .org if possible.

I understand that listing all the repositories the user has access to won't be a problem for our servers, but: do we want to add another difference between .org and .com if it's not required?

@stsewd
Copy link
Member Author

stsewd commented May 19, 2021

do we want to add another difference between .org and .com if it's not required?

We are possibly breaking user's usage of api v2 in commercial, and asking them to use apiv3 without any previous deprecation warnings. And hopefully we won't be touching api v2 anymore and deprecate it for good.

@ericholscher
Copy link
Member

ericholscher commented May 24, 2021

I don't think we got any user feedback on this, but I think it's good to merge it just in case, to not break someone's workflow. Though we can perhaps just wait until we get a support request, and then hotfix it?

@stsewd
Copy link
Member Author

stsewd commented May 24, 2021

Though we can perhaps just wait until we get a support request, and then hotfix it?

Think we can just include it now, so we don't have to re-deploy later. But true, we haven't had support requests for this.

@ericholscher
Copy link
Member

Yea, I'm guessing nobody is using it, but I'd like to not break it, so I guess let's just ship it and avoid a user having a bad experience, if they are.

@stsewd stsewd merged commit d6f7347 into master May 24, 2021
@stsewd stsewd deleted the allow-listing-on-priv-repos branch May 24, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants